M2: add JIT Builtin leaf units to lib spine smoke (#1056)#1411
Closed
PurHur wants to merge 1 commit into
Closed
Conversation
Extend compiler_lib_spine_smoke with seven Builtin units (CallArgv, IniSet, StringFunctionExists, StringHttpBuildQuery, StringSerialize, StringSuperglobalName, StringUrldecode) and drop an unparseable hexNibbleValue docblock that blocked self-host type reconstruction. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Owner
Author
|
Superseded by #1454 (consolidated M2 spine merge). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/Builtinleaf units totest/selfhost/compiler_lib_spine_smoke/main.php: CallArgv, IniSet, StringFunctionExists, StringHttpBuildQuery, StringSerialize, StringSuperglobalName, StringUrldecode.BootstrapSelfhostBundleTestlib spine smoke bundle count (157 → 164) and assert the new units.hexNibbleValuedocblock inStringUrldecode.phpthat blocked self-host type reconstruction when the unit is included in the bundle.Test plan
php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.phpvendor/bin/phpunit --filter BootstrapSelfhostBundleTest::testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits./script/bootstrap-selfhost-lib-spine-smoke-link.sh(needs LLVM/FFI toolchain in CI)Made with Cursor