fix(resources): make TipTracker.get_tip use pending state - #1206
Open
VivienP wants to merge 1 commit into
Open
Conversation
Align get_tip() with has_tip and VolumeTracker so public getters expose the same transactional view. Add regression tests for pending add and remove. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TipTracker.get_tip()withhas_tipandVolumeTrackerso public getters expose the same pending transactional state.has_tip/get_tip()views described in Tip state tracking allows for contradictory states #309 (logical tracker consistency only; hardware uncertainty is out of scope).Test plan
python -m pytest pylabrobot/resources/tip_tracker_tests.py -qget_tip()now matches its docstring during an open transaction