AGP 9 + Kotlin 2.3#205
Open
ninovanhooff wants to merge 6 commits into
Open
Conversation
Using Android Studio's AGP upgrade assistant
Using Android Studio's AGP upgrade assistant
There was a problem hiding this comment.
Pull request overview
Updates the project’s Gradle/Android build tooling to newer versions and adjusts build configuration to align with AGP 9.x behavior/toolchains.
Changes:
- Bump Gradle wrapper and version-catalog tool versions (Kotlin + AGP).
- Add Foojay toolchain resolver + introduce a daemon JVM toolchain properties file.
- Adjust shared Gradle scripts / properties for AGP 9.x defaults and remove Kotlin Android plugin application.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle | Adds Foojay toolchains resolver convention plugin. |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper distribution URL. |
| gradle/libs.versions.toml | Updates Kotlin/AGP versions and modifies plugin catalog entries. |
| gradle/gradle-daemon-jvm.properties | Adds generated daemon JVM toolchain resolution configuration. |
| gradle.properties | Adds AGP 9.x-related properties and comments; minor formatting update. |
| build.module.library.gradle | Removes Kotlin Android plugin application from shared library module script. |
| build.module.feature-and-app.gradle | Removes Kotlin Android plugin application from shared feature/app module script. |
| build.gradle | Removes Kotlin Android plugin from root plugin classpath declarations. |
| build.dep.compose.gradle | Removes Kotlin Android plugin application from shared Compose deps script. |
| .idea/gradle.xml | Removes IDE-specific Gradle JVM / annotation resolution options. |
Files not reviewed (1)
- .idea/gradle.xml: Language not supported
Comments suppressed due to low confidence (1)
build.dep.compose.gradle:4
build.dep.compose.gradleconfigures Compose, but no longer applies the Kotlin Android plugin. If module-levelplugins {}doesn’t apply Kotlin, Compose compilation will fail. Ensure Kotlin Android is applied consistently (preferably once in the shared module scripts).
android {
buildFeatures {
compose = true
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # android.dependency.excludeLibraryComponentsFromConstraints is DEPRECATED and will be removed in AGP 10.0.0 | ||
| # omitting it however, would cause AGP 9.x to output a warning | ||
| # to supress that warning, we set android.generateSyncIssueWhenLibraryConstraintsAreEnabled to false |
There was a problem hiding this comment.
Typo in comment: “supress” → “suppress”.
Suggested change
| # to supress that warning, we set android.generateSyncIssueWhenLibraryConstraintsAreEnabled to false | |
| # to suppress that warning, we set android.generateSyncIssueWhenLibraryConstraintsAreEnabled to false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this important?
keeping up with the times
Notes
Fixes #204