-
Notifications
You must be signed in to change notification settings - Fork 3
AGP 9 + Kotlin 2.3 #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ninovanhooff
wants to merge
6
commits into
develop
Choose a base branch
from
feature/template-204-agp9
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
AGP 9 + Kotlin 2.3 #205
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
827f7a1
ADD gradle toolchains
ninovanhooff 5de0460
CHANGE AGP to 8.13.2 and kotlin to 2.3.20
ninovanhooff 7fa9cdf
CHANGE AGP to 9.1.0 and Gradle to 9.3.1
ninovanhooff 49db99d
REMOVE properties from gradle.properties that are not required
ninovanhooff 9759a02
REMOVE kotlin-android plugin and use builtin-kotlin
ninovanhooff b2aa3fd
CHANGE gradle.properties to suppress a useless warning
ninovanhooff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| apply plugin: 'kotlin-android' | ||
|
|
||
| android { | ||
| buildFeatures { | ||
| compose = true | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |||||
| # any settings specified in this file. | ||||||
| # For more details on how to configure your build environment visit | ||||||
| # http://www.gradle.org/docs/current/userguide/build_environment.html | ||||||
|
|
||||||
| # Specifies the JVM arguments used for the daemon process. | ||||||
| # The setting is particularly useful for tweaking memory settings. | ||||||
| org.gradle.jvmargs=-Xmx4g -Dfile.encoding=UTF-8 | ||||||
|
|
@@ -15,9 +16,28 @@ org.gradle.jvmargs=-Xmx4g -Dfile.encoding=UTF-8 | |||||
| # Android operating system, and which are packaged with your app's APK | ||||||
| # https://developer.android.com/topic/libraries/support-library/androidx-rn | ||||||
| android.useAndroidX=true | ||||||
|
|
||||||
| # Kotlin code style for this project: "official" or "obsolete": | ||||||
| kotlin.code.style=official | ||||||
|
|
||||||
| # Enables namespacing of each library's R class so that its R class includes only the | ||||||
| # resources declared in the library itself and none from the library's dependencies, | ||||||
| # thereby reducing the size of the R class for that library | ||||||
| android.nonTransitiveRClass=true | ||||||
| android.nonTransitiveRClass=true | ||||||
|
|
||||||
| # AGP 9.x enables compile-time R class for app modules by default; keeping false preserves existing build behavior. | ||||||
| #android.enableAppCompileTimeRClass=false | ||||||
|
|
||||||
| # Enables improved dependency version constraint resolution introduced in AGP 9.x. | ||||||
| android.dependency.useConstraints=true | ||||||
|
|
||||||
| # AGP 9.x enables R8 strict full mode by default; keeping false avoids failures from non-conforming third-party keep rules. | ||||||
| android.r8.strictFullModeForKeepRules=false | ||||||
|
|
||||||
| # android.dependency.excludeLibraryComponentsFromConstraints is DEPRECATED and will be removed in AGP 10.0.0 | ||||||
| # omitting it however, would cause AGP 9.x to output a warning | ||||||
| # to supress that warning, we set android.generateSyncIssueWhenLibraryConstraintsAreEnabled to false | ||||||
|
||||||
| # to supress that warning, we set android.generateSyncIssueWhenLibraryConstraintsAreEnabled to false | |
| # to suppress that warning, we set android.generateSyncIssueWhenLibraryConstraintsAreEnabled to false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #This file is generated by updateDaemonJvm | ||
| toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/ec393a8d1f984107f9ae6ce8f45a661f/redirect | ||
| toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/2e70db4a6fa54a1270e3a3d74da52fcc/redirect | ||
| toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/ec393a8d1f984107f9ae6ce8f45a661f/redirect | ||
| toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/2e70db4a6fa54a1270e3a3d74da52fcc/redirect | ||
| toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/b30866b18394d55c95dc662594302c0a/redirect | ||
| toolchainUrl.MAC_OS.X86_64=https\://api.foojay.io/disco/v3.0/ids/88dd3a3df8e2336eb284d6b9b6b98d9c/redirect | ||
| toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/ec393a8d1f984107f9ae6ce8f45a661f/redirect | ||
| toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/2e70db4a6fa54a1270e3a3d74da52fcc/redirect | ||
| toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/1c2ee0010b0528b7376f108f13ea45c3/redirect | ||
| toolchainVendor=AMAZON | ||
| toolchainVersion=21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #Thu Jan 26 10:33:34 CET 2023 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.