Templates: open URLs in disposables - #665
Open
notmuchtohide wants to merge 6 commits into
Open
Conversation
This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software URLs (project website, donation pages, etc.) in disposables. This allows the user to check the project website safely before installing apps, while reducing the need for screenshots to recognize the apps in Gnome Software (QubesOS/qubes-issues#10983). Previously, URLs were opened in offline browsers. However, if Gnome Software had access to the updates proxy (e.g. for Flatpak related actions) it would pass the proxy configurations to the browser and open the URL online. Service ConditionGroup borrowed from qubes-notification-agent.
Contributor
|
Member
I'm not sure if this makes sense here, opening all urls in a template in disposables makes I think a lot of sense and is more resilient to other package managers using packagekit or whatnot.
agreed on that |
Member
|
Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 71.31% 71.71% +0.39%
==========================================
Files 3 3
Lines 502 502
==========================================
+ Hits 358 360 +2
+ Misses 144 142 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
multi-user is a system target and not a user target.
This was referenced Aug 27, 2026
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026082703-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 31 fixed
Unstable testsDetails
Performance TestsPerformance degradation:17 performance degradations
Remaining performance tests:94 tests
|
This was referenced Aug 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software URLs (project website, donation pages, etc.) in disposables.
This allows the user to check the project website safely before installing apps, while reducing the need for screenshots to recognize the apps in Gnome Software (QubesOS/qubes-issues#10983).
Previously, URLs were opened in offline browsers. However, if Gnome Software had access to the updates proxy (e.g. for Flatpak related actions) it would pass the proxy configurations to the browser and open the URL online.
Service
ConditionGroupborrowed from qubes-notification-agent.