perf(qubes-hcl-report): cache the yaml output until the next reboot - #877
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
=======================================
Coverage 70.70% 70.70%
=======================================
Files 61 61
Lines 14315 14315
=======================================
Hits 10121 10121
Misses 4194 4194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 26, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026082703-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 31 fixed
Unstable testsDetails
Performance TestsPerformance degradation:17 performance degradations
Remaining performance tests:94 tests
|
This was referenced Aug 26, 2026
marmarek
requested changes
Aug 27, 2026
| then | ||
| if [[ "$(cat "$CACHE_BOOT_ID_FILE" 2>/dev/null)" = "$BOOT_ID" ]] && | ||
| [[ -s "$CACHE_FILE" ]] | ||
| # tested before reading, so that having no cache yet does not report an |
Contributor
Author
There was a problem hiding this comment.
I added this comment because it was not (immediately) clear for me.
This was referenced Aug 27, 2026
marmarek
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collecting the data shells out to lspci, dmidecode, xl info and xl dmesg. Callers that only want the yaml output pay for that on every run, for example Qubes Global Config and
tests/dispvm_perf.py.Everything in the yaml output is fixed for the lifetime of a boot, so it is now cached under the user's cache directory keyed on
/proc/sys/kernel/random/boot_id.Only
--yaml-onlyis cached. The support files bundle rawlspci -nnvkoutput, which does change within a boot, eg when a PCI device is attached to a qube and bound to pciback. A report collected with an incompletexl dmesgring buffer is not cached either, since its virtualization fields come out empty.--no-cachecollects the data again.QubesOS/qubes-issues#11081