misc: avoid malformed MIME cache for catch-all glob - #672
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 3 3
Lines 502 502
=======================================
Hits 360 360
Misses 142 142 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
besendorf
force-pushed
the
fix-mime-cache-reproducibility
branch
2 times, most recently
from
August 25, 2026 11:27
3300c75 to
1b8c603
Compare
update-mime-database stores suffix globs in the reverse suffix tree in mime.cache. The "*" catch-all has an empty suffix and triggers shared-mime-info#230, leaving a malformed node whose contents can vary across builds. Use "?*" instead. MIME glob syntax follows fnmatch(3), so it still matches every valid, non-empty filename, but is stored as a general glob and bypasses the broken suffix-tree path. Fixes QubesOS/qubes-issues#9159.
besendorf
force-pushed
the
fix-mime-cache-reproducibility
branch
from
August 25, 2026 11:27
1b8c603 to
e92cb8b
Compare
This was referenced Aug 26, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026082616-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 30 fixed
Unstable testsDetails
Performance TestsPerformance degradation:18 performance degradations
Remaining performance tests:93 tests
|
This was referenced Aug 26, 2026
Merged
marmarek
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
*catch-all glob forapplication/qubes-untrusted-filewith?*to make the generated MIME cache reproducible.Background
update-mime-databasestores suffix globs in a reverse suffix tree insidemime.cache. The existing*pattern has an empty suffix and triggers shared-mime-info#230, producing a malformed, unlinked tree node whose contents can vary between builds. This causes otherwise identical packages to differ.Shared MIME glob patterns use
fnmatch(3)syntax.?*matches one or more characters, which is equivalent to*for valid, non-empty filenames. Because it is handled as a general glob instead of an empty suffix, it bypasses the broken suffix-tree path while preserving the weight-100 fallback behavior.Fixes QubesOS/qubes-issues#9159.