[Fix] Fast Brain query details fall back to raw JSON when truncated - #1748
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Fix] Fast Brain query details fall back to raw JSON when truncated#1748roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
rawInput.arguments.queryshape without changing persistence contracts.Why this change was made
Fast pretty-serializes integration results and truncates large outputs at 50,000 characters. Brain query results can cross that limit, making the persisted text invalid JSON; smaller entity results remained parseable, so only query rows bypassed YAML formatting and lost their visible query input.
Impact
Truncated Fast Brain query rows now show the persisted query alongside the complete preserved head/tail output in YAML, while generic invalid or plain-text results keep their existing treatment. Focused ACP detail, tool-row, and Fast transcript tests pass, along with web typecheck, ESLint, formatting, and repository pre-push checks. Local browser proof was unavailable because the sandbox dev account remained on the setup wizard; the regression test exercises the canonical persisted Fast payload shape directly.
Related PRs