Skip to content

[Fix] Fast Brain query details fall back to raw JSON when truncated #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
+124 −17
Draft

[Fix] Fast Brain query details fall back to raw JSON when truncated #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 103 additions & 0 deletions apps/web/src/app/(sandbox)/sessions/[sessionId]/FastSessionTranscript.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 21 additions & 17 deletions apps/web/src/app/(sandbox)/task/[taskId]/messages/acp/AcpToolDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,27 +116,31 @@ function formatToolDetails(
visibleToolInput: Record<string, string> | null,
): { code: string; isStructured: boolean } | undefined {
if (!text) return undefined;
const hasVisibleToolInput =
visibleToolInput && Object.keys(visibleToolInput).length > 0;
let result: unknown = text;

try {
const result = JSON.parse(text) as unknown;
if (!result || typeof result !== 'object') {
return { code: text, isStructured: false };
}

const details =
!Array.isArray(result) &&
visibleToolInput &&
Object.keys(visibleToolInput).length > 0
? { ...(result as Record<string, unknown>), ...visibleToolInput }
: result;

return {
code: YAML.stringify(details, { indent: 2, lineWidth: 0 }).trimEnd(),
isStructured: true,
};
result = JSON.parse(text) as unknown;
} catch {
return { code: text, isStructured: false };
// Keep unparseable output intact below.
}

const details =
result && typeof result === 'object'
? !Array.isArray(result) && hasVisibleToolInput
? { ...(result as Record<string, unknown>), ...visibleToolInput }
: result
: hasVisibleToolInput
? { ...visibleToolInput, output: result }
: null;

if (!details) return { code: text, isStructured: false };

return {
code: YAML.stringify(details, { indent: 2, lineWidth: 0 }).trimEnd(),
isStructured: true,
};
}

function getVisibleToolInput(
Expand Down
Loading