fix: check sqlmesh version before sqlglot/schema#4898
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Reorders version mismatch checks to prioritize SQLMesh version before schema and SQLGlot, and removes a duplicate SQLMesh check.
- Moves the SQLMesh version validation to occur immediately after the remote version fetch.
- Deletes the redundant SQLMesh version check block that followed schema/SQLGlot checks.
Comments suppressed due to low confidence (2)
sqlmesh/core/state_sync/base.py:248
- Add unit tests to cover the new early SQLMesh version mismatch path to ensure this scenario is properly tested.
if major_minor(SQLMESH_VERSION) != major_minor(versions.sqlmesh_version):
kelsin
approved these changes
Jul 3, 2025
eakmanrq
force-pushed
the
eakmanrq/check_sqlmesh_version_first
branch
from
7f96dab to
6ce8efc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if a user was running a version that didn't match the remote SQLMesh version, they would likely see a schema or sqlglot version mismatched error before SQLMesh. Erroring on SQLMesh is more useful since it makes it more clear what the issue is - version/SQLGLot should just be backup checks.