Skip to content

fix: check sqlmesh version before sqlglot/schema #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eakmanrq merged 1 commit into from
Jul 3, 2025
Merged

fix: check sqlmesh version before sqlglot/schema #4898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions sqlmesh/core/state_sync/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,15 @@ def raise_error(
f"{lib} (local) is using version '{local}' which is behind '{remote}' (remote).{upgrade_suggestion}"
)

if major_minor(SQLMESH_VERSION) != major_minor(versions.sqlmesh_version):
raise_error(
"SQLMesh",
SQLMESH_VERSION,
versions.sqlmesh_version,
remote_package_version=versions.sqlmesh_version,
ahead=major_minor(SQLMESH_VERSION) > major_minor(versions.sqlmesh_version),
Comment thread
eakmanrq marked this conversation as resolved.
)

if SCHEMA_VERSION != versions.schema_version:
raise_error(
"SQLMesh",
Expand All @@ -263,15 +272,6 @@ def raise_error(
ahead=major_minor(SQLGLOT_VERSION) > major_minor(versions.sqlglot_version),
)

if major_minor(SQLMESH_VERSION) != major_minor(versions.sqlmesh_version):
raise_error(
"SQLMesh",
SQLMESH_VERSION,
versions.sqlmesh_version,
remote_package_version=versions.sqlmesh_version,
ahead=major_minor(SQLMESH_VERSION) > major_minor(versions.sqlmesh_version),
)

return versions

@abc.abstractmethod
Expand Down
2 changes: 1 addition & 1 deletion tests/core/state_sync/test_state_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2091,7 +2091,7 @@ def test_version_schema(state_sync: EngineAdapterStateSync, tmp_path) -> None:

with pytest.raises(
SQLMeshError,
match=rf"SQLMesh \(local\) is using version '{SCHEMA_VERSION}' which is ahead of '0'",
match=rf"SQLMesh \(local\) is using version '{SQLMESH_VERSION}' which is ahead of '0.0.0' \(remote\). Please run a migration \('sqlmesh migrate' command\).",
):
state_sync.get_versions()

Expand Down