fix: add CoroutineClosure to maybe_drop_guard type list#480
Open
SebTardif wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #479
maybe_drop_guardinliveness.rsdetermines whether a type should suppress falseunused variablelint warnings when used as a drop guard. It explicitly liststy::Closureandty::Coroutinebut missesty::CoroutineClosure, causing false positive warnings when async closures are used as drop guards.Failure scenario
When a user writes
let _guard = create_async_closure();as a drop guard pattern, the lint pass does not recognize the async closure type as a valid drop guard and emits a spuriousunused variablewarning.Fix
Add
ty::CoroutineClosure(..)to thematches!list, alongsidety::Closureandty::Coroutine.Bug origin
The
CoroutineClosurevariant was added to TyKind for async closures (stable since Rust 1.85). Themaybe_drop_guardfunction was not updated to include the new variant.