fix: add CoroutineClosure to describe_field_from_ty for capture names#482
Open
SebTardif wants to merge 2 commits into
Open
fix: add CoroutineClosure to describe_field_from_ty for capture names#482SebTardif wants to merge 2 commits into
SebTardif wants to merge 2 commits into
Conversation
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
…neClosure Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #478
describe_field_from_tyincompiler/rustc_borrowck/src/diagnostics/mod.rsmatchesty::Closure | ty::Coroutineto resolve captured variable names in borrow checker diagnostics, but missesty::CoroutineClosure. This causes borrow checker errors involving async closure captures to show "field 0" instead of the actual variable name.Failure scenario
When the borrow checker reports an error involving a captured variable inside an async closure, the diagnostic shows the numeric field index (e.g., "cannot borrow
field 0as mutable") instead of the variable name (e.g., "cannot borrowdataas mutable"). This makes errors harder to understand.Fix
Add
ty::CoroutineClosure(def_id, _)to the existing match arm alongsidety::Closureandty::Coroutine. Theclosure_capturesAPI works identically for all three closure types.Bug origin
The
CoroutineClosurevariant was added for async closures (stable since Rust 1.85). This diagnostic path was not updated.