Consolidate isValidGuid() functions in SID

[BurningAXE]

JIRA ticket
Will be released in: 2026.3.0

Notable changes

• Drops the String-based validator and keeps the REGEX one to be consistent with BFSID

Testing guidance

• Everything should work as before (famous last words!)

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[Copilot]

Pull request overview

This PR removes the duplicate isValidGuid() String extension and standardizes callers on the existing core.tools.utils implementation, while also extending the confirm-flow response contract to optionally include CoSync subjectActions and mapping that payload through the client API response mappers.

Changes:

• Consolidates isValidGuid() usage by deleting the core.tools.extentions implementation and updating imports/call sites to core.tools.utils.
• Adds subjectActions: String? to ActionResponse.ConfirmActionResponse and threads this through CommCare/LibSimprints response mappers (with test coverage updates).
• Updates ClientApiViewModel.handleConfirmResponse() to optionally generate CoSync enrolment-record creation payload on confirm responses.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
infra/orchestrator-data/src/main/java/com/simprints/infra/orchestration/data/ActionResponse.kt	Extends ConfirmActionResponse to carry optional subjectActions payload.
infra/core/src/test/java/com/simprints/core/tools/utils/StringUtilsTest.kt	Adds broader unit coverage for the canonical isValidGuid() + randomUUID().
infra/core/src/test/java/com/simprints/core/tools/extentions/StringExtTest.kt	Removes test tied to the deleted duplicate extension implementation.
infra/core/src/main/java/com/simprints/core/tools/extentions/String.ext.kt	Deletes the duplicate isValidGuid() extension implementation.
feature/select-subject/src/main/java/com/simprints/feature/selectsubject/screen/SelectSubjectViewModel.kt	Switches isValidGuid() import to the consolidated utils location.
feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ResetExternalCredentialsInSessionUseCase.kt	Switches isValidGuid() import to the consolidated utils location.
feature/client-api/src/main/java/com/simprints/feature/clientapi/ClientApiViewModel.kt	Generates optional CoSync subjectActions for confirm responses.
feature/client-api/src/main/java/com/simprints/feature/clientapi/mappers/response/LibSimprintsResponseMapper.kt	Appends CoSync data for confirm (and enrol) response bundles.
feature/client-api/src/main/java/com/simprints/feature/clientapi/mappers/response/CommCareResponseMapper.kt	Appends CoSync data for confirm (and enrol) CommCare bundles.
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/OdkResponseMapperTest.kt	Updates confirm response construction for new subjectActions param.
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/LibSimprintsResponseMapperTest.kt	Adds/updates tests to verify CoSync mapping for confirm responses.
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/CommCareResponseMapperTest.kt	Adds/updates tests to verify CoSync mapping for confirm responses.
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/response/ActionToIntentMapperTest.kt	Updates confirm response construction for new subjectActions param.
feature/client-api/src/test/java/com/simprints/feature/clientapi/ClientApiViewModelTest.kt	Updates confirm request helper and adds tests for CoSync generation conditions.

[alexandr-simprints]

Is it necessary to include the entire #1759 in this PR?

[BurningAXE]

Is it necessary to include the entire #1759 in this PR?

Nope. It builds on it's branch so points to that temporarily. Meanwhile I force-pushed a change to the source branch. Anyway, I'll sort it out and leave only the relevant commit here.

[luhmirin-s]

I suggest doing an interactive rebase to before proceeding with this branch.

[BurningAXE]

I suggest doing an interactive rebase to before proceeding with this branch.

Done and I'll point to main once base PR is merged. Sorry for the temp mess.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud