Skip to content

Consolidate isValidGuid() functions in SID #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BurningAXE merged 1 commit into from
Jul 30, 2026
Merged

Consolidate isValidGuid() functions in SID #1760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feature/client-api/src/main/java/com/simprints/feature/clientapi/ClientApiViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import androidx.lifecycle.viewModelScope
import com.simprints.core.livedata.LiveDataEvent
import com.simprints.core.livedata.LiveDataEventWithContent
import com.simprints.core.livedata.send
import com.simprints.core.tools.extentions.isValidGuid
import com.simprints.core.tools.extentions.toJsonElementMap
import com.simprints.core.tools.time.TimeHelper
import com.simprints.core.tools.utils.isValidGuid
import com.simprints.feature.clientapi.exceptions.InvalidRequestException
import com.simprints.feature.clientapi.extensions.toMap
import com.simprints.feature.clientapi.mappers.request.IntentToActionMapper
Expand Down
2 changes: 1 addition & 1 deletion .../simprints/feature/externalcredential/usecase/ResetExternalCredentialsInSessionUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.simprints.feature.externalcredential.usecase

import com.simprints.core.SessionCoroutineScope
import com.simprints.core.tools.extentions.isValidGuid
import com.simprints.core.tools.utils.isValidGuid
import com.simprints.feature.externalcredential.ExternalCredentialMapper
import com.simprints.feature.externalcredential.ExternalCredentialSearchResult
import com.simprints.infra.config.store.ConfigRepository
Expand Down
2 changes: 1 addition & 1 deletion ...ubject/src/main/java/com/simprints/feature/selectsubject/screen/SelectSubjectViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import com.simprints.core.SessionCoroutineScope
import com.simprints.core.domain.tokenization.TokenizableString
import com.simprints.core.livedata.LiveDataEventWithContent
import com.simprints.core.livedata.send
import com.simprints.core.tools.extentions.isValidGuid
import com.simprints.core.tools.time.TimeHelper
import com.simprints.core.tools.utils.isValidGuid
import com.simprints.feature.externalcredential.ExternalCredentialSearchResult
import com.simprints.feature.externalcredential.usecase.ResetExternalCredentialsInSessionUseCase
import com.simprints.feature.selectsubject.SelectSubjectParams
Expand Down
10 changes: 0 additions & 10 deletions infra/core/src/main/java/com/simprints/core/tools/extentions/String.ext.kt
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions infra/core/src/test/java/com/simprints/core/tools/extentions/StringExtTest.kt
View file
Open in desktop

This file was deleted.

36 changes: 36 additions & 0 deletions infra/core/src/test/java/com/simprints/core/tools/utils/StringUtilsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package com.simprints.core.tools.utils

import com.google.common.truth.Truth.assertThat
import org.junit.Test

class StringUtilsTest {
@Test
fun `Is valid UUID`() {
assertThat("".isValidGuid()).isFalse()
assertThat("test".isValidGuid()).isFalse()

assertThat("63d26965-e68c-447c-9ee9-5aba2ebf589c".isValidGuid()).isTrue()
assertThat("85500708-52D9-4A06-855F-391469E5C220".isValidGuid()).isTrue()
}

@Test
fun `Is not valid UUID when malformed`() {
assertThat("1-1-1-1-1".isValidGuid()).isFalse()
assertThat("63d26965-e68c-447c-9ee9-5aba2ebf589".isValidGuid()).isFalse()
assertThat(" 63d26965-e68c-447c-9ee9-5aba2ebf589c ".isValidGuid()).isFalse()
assertThat("63d26965e68c447c9ee95aba2ebf589c".isValidGuid()).isFalse()
}

@Test
fun `Is not valid UUID when version or variant is not supported`() {
// Only versions 3 and 4 with RFC 4122 variants are accepted
assertThat("0003eaf0-9044-6ead-fd6e-600d1b616ba5".isValidGuid()).isFalse()
assertThat("123e4567-e89b-12d3-a456-426614174000".isValidGuid()).isFalse()
assertThat("b2f3e4c5-6789-4fab-cdef-2345678901bc".isValidGuid()).isFalse()
}

@Test
fun `randomUUID generates valid UUID`() {
assertThat(randomUUID().isValidGuid()).isTrue()
}
}