SLVSCODE-1655 Remove client-side on-demand download for C++ and C#

[nquinquenel]

No description provided.

[hashicorp-vault-sonar-prod]

SLVSCODE-1655

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[sonar-review-alpha]

Summary

What changed

This PR removes client-side on-demand downloads for C/C++ (CFamily) and C# (OmniSharp) analyzers. Previously, when a user needed these analyzers, they would be downloaded at runtime with user prompts and progress dialogs. Now these analyzers must be pre-bundled in the extension or managed differently.

Key removals

• omnisharpDownload.mjs: Entire module for downloading OmniSharp distributions across platforms — removed from all build scripts
• src/cfamily/ondemand.ts: On-demand download logic for CFamily analyzer, including signature verification and cleanup routines
• Tests: Removed test suite for on-demand analyzer lifecycle (ondemand.test.ts)
• Build configuration: Removed OMNISHARP_VERSION constant and all calls to download functions from build scripts (common.mjs, package.mjs, package-all-microsoft.mjs, package-all-ovsx.mjs)
• Language server integration: Removed CFamily jar injection from runtime (maybeAddCFamilyJar call), C# path configuration, and OmniSharp directory configuration

Structural changes

• languageServerCommand() is now synchronous instead of async (no longer waits for CFamily downloads)
• Language server version bumped from 5.1.0.78319 → 5.2.0.78336 (likely includes analyzer support changes)

What reviewers should know

For reviewers

Start with: The extension initialization changes (src/extension.ts and src/lsp/server.ts) to understand how C# and C++ analyzers are now configured. The removal of omnisharpDirectory, csharpOssPath, and csharpEnterprisePath configs shows these no longer need runtime configuration.

Watch for:

• Verify that the language server version bump (5.2.0) actually includes pre-bundled C/C++ and C# analyzers — the build changes assume analyzers are included elsewhere
• Build scripts for Microsoft and OpenVSX marketplaces both lose OmniSharp downloads — confirm this doesn't create different VSIX packages than intended
• The maybeAddCFamilyJar() removal means the extension no longer shows progress dialogs for CFamily downloads — confirm this UX change is acceptable

Non-obvious decisions:

• Build scripts no longer distinguish between Microsoft (with OmniSharp) and OpenVSX (without) packages in code — they're now treated identically. Comments about this distinction have been removed.
• Cleanup functions (cleanOmnisharpDir) are removed, so the extension won't garbage-collect old analyzer versions anymore

Testing implications: The old tests verified download and cleanup logic — these are gone. Ensure there are new tests (if needed) covering the new analyzer delivery mechanism.

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback