fix: action.yml default meta-repo-ref must be floating major tag#40
Merged
TMHSDigital merged 1 commit intomainfrom Apr 26, 2026
Merged
Conversation
The `meta-repo-ref` default in .github/actions/drift-check/action.yml was hardcoded to 'v1.7' and never updated when 1.8 and 1.9 shipped. Tool repos consuming the action without explicit override would get the meta-repo checked out at v1.7 regardless of which version of the action they pinned, producing inverse-direction version-signal drift if their signals ever moved past 1.7.0. Fixes by changing the default to 'v1' (the auto-maintained MAJOR floating tag per DTD#14). Future MINORs auto-flow through this default without requiring action.yml edits. Surfaced during the v1.7.0 -> v1.9.0 ecosystem signal rollout when the Home-Lab canary's drift-check failed with 35 inverse-direction warnings: tool signals at 1.9.0 vs action's hardcoded v1.7 meta-VERSION. Adds regression test asserting the default matches floating-major pattern (v[0-9]+) to prevent re-introduction. Refs TMHSDigital/Home-Lab-Developer-Tools#18. Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Made-with: Cursor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a stale hardcoded default in the drift-check composite action surfaced during the v1.9.0 ecosystem signal rollout.
The
meta-repo-refinput defaulted tov1.7which was never updated when 1.8/1.9 shipped. Tool repos consuming the action without explicit override would silently use v1.7 of the meta-repo's checker code, producing inverse-direction version-signal drift if tool signals moved past 1.7.0.Fix: change default to
v1(auto-maintained MAJOR floating tag per DTD#14). Future MINORs auto-flow through.Adds regression test guarding the floating-major pattern.
Will unblock the v1.9.0 ecosystem signal rollout (Home-Lab canary TMHSDigital/Home-Lab-Developer-Tools#18, batch to follow).
VERSION: 1.9.0 -> 1.9.1 (PATCH, default-behavior bug fix).