Added practice field mode with single source of truth (not done, build-time only right now)#3790
Open
Muxite wants to merge 7 commits into
Open
Added practice field mode with single source of truth (not done, build-time only right now)#3790Muxite wants to merge 7 commits into
Muxite wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new field mode with custom sizing primarily targeted for making smaller fields, but larger fields work as well.
Current approach has a .bzl file storing a dictionary of practice field dimensions, the bazel does text replacement at build-time. This allows the er-force sim dimensions that feed into SSL vision to be synced with createPracticeField().
Testing Done
Ran ./tbots.py run thunderscope --division practice which successfully played a game with no errors seen. Need to write unit tests. No field testing done yet, I hope to do that after my final.
Resolved Issues
resolves #3359
Length Justification and Key Files to Review
src/shared/practice_field_dims.bzl
src/proto/world.proto
src/software/world/field.h and field.cpp
Converted some meter constants into values proportional to field dimensions:
src/software/ai/hl/stp/play/kickoff_friendly/kickoff_friendly_play_fsm
src/software/ai/hl/stp/tactic/goalie/goalie_fsm
src/software/ai/hl/stp/play/shoot_or_chip/shoot_or_chip_play_fsm
src/software/ai/hl/stp/play/penalty_kick/penalty_kick_play_fsm
src/software/simulation/er_force_simulator.cpp -> loads "practice.txt"
src/software/er_force_simulator_main.cpp -> new cli option
src/proto/message_translation/tbots_protobuf.py -> adjusts robot spawns for field dims.
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue