Skip to content

Add missing required tactic proto fields in tests#3794

Merged
nycrat merged 1 commit into
masterfrom
avah/fix_tactics_required_params
Jun 22, 2026
Merged

Add missing required tactic proto fields in tests#3794
nycrat merged 1 commit into
masterfrom
avah/fix_tactics_required_params

Conversation

@nycrat

@nycrat nycrat commented Jun 21, 2026

Copy link
Copy Markdown
Member

Description

In a few simulated test files, the tactic protos created do not have all the required fields. While the tests still run in most instances, this is technically not correct since we want all the required fields to be explicitly set when creating. This has caused issues when I was working on #3540, where it would crash the test: 2026-06-21 15:58:52,751 - [ERROR] - [Thread-32 (__send_protobuf)] - root - (threaded_unix_sender.py).__send_protobuf(60) - Received an invalid proto of type TbotsProto.AssignedTacticPlayControlParams

Testing Done

Ran sim test suite, everything passes still.

Resolved Issues

N/A

Length Justification and Key Files to Review

N/A

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@adrianchan787

adrianchan787 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Wait actually could you take a look at GoalieTactic?
image
image
If my understanding of protos is correct, i'm not sure this is right? everything else I think is okay

@nycrat

nycrat commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Wait actually could you take a look at GoalieTactic? image image If my understanding of protos is correct, i'm not sure this is right? everything else I think is okay

Oh right theres a difference between the FSMs and the tactic protos. You can find the fields for a specific tactic in src/proto/tactic.proto:

image\

So the goalie proto there is fine

@nycrat nycrat merged commit 52a6bb5 into master Jun 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants