Add missing required tactic proto fields in tests#3794
Merged
Conversation
williamckha
approved these changes
Jun 21, 2026
adrianchan787
approved these changes
Jun 22, 2026
Contributor
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
In a few simulated test files, the tactic protos created do not have all the required fields. While the tests still run in most instances, this is technically not correct since we want all the required fields to be explicitly set when creating. This has caused issues when I was working on #3540, where it would crash the test:
2026-06-21 15:58:52,751 - [ERROR] - [Thread-32 (__send_protobuf)] - root - (threaded_unix_sender.py).__send_protobuf(60) - Received an invalid proto of type TbotsProto.AssignedTacticPlayControlParamsTesting Done
Ran sim test suite, everything passes still.
Resolved Issues
N/A
Length Justification and Key Files to Review
N/A
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue