Skip to content

Field testing improvements#3807

Open
nycrat wants to merge 15 commits into
avah/run_tests_within_thunderscopefrom
avah/better_field_test_support
Open

Field testing improvements#3807
nycrat wants to merge 15 commits into
avah/run_tests_within_thunderscopefrom
avah/better_field_test_support

Conversation

@nycrat

@nycrat nycrat commented Jun 25, 2026

Copy link
Copy Markdown
Member

Description

This is a stacked PR: #3744 #3806 #3807

This PR adds better field testing with the following features:

  • Field robot ids are automatically mapped to the simulated ids
    • e.g. if we only have robot 3 on the field, it will execute the tactics and validations of robot 0 written in the test. If we only have robot 2 and 5, they will represent simulated robot 0 and 1.
  • Robots are sent move commands to their starting positions with set_world_state
    • The field test runner waits until every robot is near its target position and orientation
    • Note that ball location cannot yet be set due to inconsistent robot ball placement
    • Also note that initial robot velocities cannot be set

Testing Done

Ran move_tactic_field_test and observed robots setting up. Rest of the test ran properly.

Resolved Issues

(part of stack pr)

Length Justification and Key Files to Review

N/A

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat force-pushed the avah/better_field_test_support branch 3 times, most recently from 702ae94 to 86d2ccc Compare June 25, 2026 18:47
@nycrat nycrat force-pushed the avah/better_field_test_support branch from 86d2ccc to 163e8fe Compare June 25, 2026 18:49
@nycrat nycrat changed the title Field testing improvements [DRAFT] Field testing improvements Jun 25, 2026
nycrat and others added 5 commits June 25, 2026 16:15
- Collapse _all_robots_at_targets, _target_error, and _smallest_angle_diff
  into the single _describe_robots_not_at_targets; the wait loop reuses its
  result for both the arrival check and the timeout error message
- Drop the redundant self.is_yellow_friendly assignment (set by the base
  class) and the unused self.initial_world

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@nycrat nycrat requested a review from GrayHoang June 26, 2026 05:57
@nycrat nycrat changed the title [DRAFT] Field testing improvements Field testing improvements Jun 26, 2026
@nycrat nycrat marked this pull request as ready for review June 26, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants