Field testing improvements#3807
Open
nycrat wants to merge 15 commits into
Open
Conversation
This was referenced Jun 25, 2026
702ae94 to
86d2ccc
Compare
86d2ccc to
163e8fe
Compare
- Collapse _all_robots_at_targets, _target_error, and _smallest_angle_diff into the single _describe_robots_not_at_targets; the wait loop reuses its result for both the arrival check and the timeout error message - Drop the redundant self.is_yellow_friendly assignment (set by the base class) and the unused self.initial_world Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a stacked PR: #3744 #3806 #3807
This PR adds better field testing with the following features:
Testing Done
Ran move_tactic_field_test and observed robots setting up. Rest of the test ran properly.
Resolved Issues
(part of stack pr)
Length Justification and Key Files to Review
N/A
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue