Fix mirrored ball kick velocity on inverted fullsystem tab#3813
Open
annieisawesome2 wants to merge 3 commits into
Open
Fix mirrored ball kick velocity on inverted fullsystem tab#3813annieisawesome2 wants to merge 3 commits into
annieisawesome2 wants to merge 3 commits into
Conversation
Member
|
@annieisawesome2 could you update this PR with the fixes we talked about in-person when you have time? |
Contributor
Author
Updated! Sorry for the delay. |
nycrat
approved these changes
Jul 5, 2026
nycrat
left a comment
Member
There was a problem hiding this comment.
Good work! Just make sure to pull from master for a bugfix that is causing ci to fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes mirrored ball kick behaviour on the yellow fullsystem.
When placing the ball with Shift+click and Shift+drag, the Blue and Yellow tabs can use different coordinate frames depending on friendly_colour_yellow and referee.blue_team_on_positive_half. On the inverted tab, the move preview line pointed toward the mouse (opposite of the intended slingshot direction).
Changes made:
Converted simulator-space velocity to display-space for rendering.
Use it when drawing the kick preview line so drag-back to shoot-forward matches blue fullsystem.
On release, negate velocity into a local ball_velocity before sending to the simulator (instead of mutating self.ball_velocity_vector), so preview and simulator send stay consistent
Testing Done
Try the shift click on both blue and yellow fullsystems.
Screen.Recording.2026-07-04.at.7.37.26.AM.mov
Resolved Issues
#3761
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue