HVFB with safety thresholds#3816
Conversation
…into feat-hvfb-test
…into feat-hvfb-test
| { | ||
| pinMode(HV_SENSE, INPUT); | ||
| // Currently unused | ||
| pinMode(FLYBACK_FAULT, INPUT); |
There was a problem hiding this comment.
Taking a look in Altium, the FLYBACK_FAULT pin (pin 27) isn't actually connected to anything. Further, there is no independent flyback fault pin on the LT3750 itself. The DONE pin will go high on a fault condition as per the datasheet (page 4 here). Or just look at this image:
I.e: is there any reason to have this pin? It's also unused so perhaps it'd make sense to just delete it
There was a problem hiding this comment.
I agree, good catch. That line can be removed. Ideally, DONE would take on fault behaviour as you mentioned, however the DONE pin does not work on at least one powerboard and has not been validated for many other boards. So while I intend to incorporate DONE in the future to take on the role of fault logic, it could also be removed.
|
Closing this PR in favour of #3829, which we tested at comp and confirmed works, |
Description
This is an extension of #3791, which added the minimal HVFB implementation.
This PR replaces the unconditional 500 ms LT3750 retrigger behaviour with voltage-based charge control. It is intended to provide more consistent operating voltage across boards whose hardware flyback feedback currently stops at different voltages (200V and 240V). It should also eliminate the scenario of flyback charging during active capacitor discharging.
Key changes:
Testing Done
No successful testing has been performed. Furthermore, this was the active code when powerboard 3 caught fire. While the root cause is likely hardware-based, it has not been determined.
The impact of non-EMA reading for charge control should be validated; we may wish to further tune the trade-off between response time and filtering.
Resolved Issues
Related to #3791.
Length Justification and Key Files to Review
Key files:
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue