Allow Sim to have Zero Robots#3832
Open
sauravbanna wants to merge 9 commits into
Open
Conversation
…in the case of 0 robots
…er around robotstates to differentiate between empty vs unset robots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Right now, we have a check in sim that prevents us from clearing out all the robots in sim. In Sandbox mode, this means that we can remove all but the last robot.
We also rely on there being at least 1 robot on the field to properly update the latest timestamp for each Team. However, we get this timestamp with the overall Vision packet anyway and so should handle the case where we have no robots.
Changes
Removed this check to allow for 0 robots. Along with this, added a wrapper around the
yellow_robots/blue_robotsfields inWorldStateto differentiate between an empty list of robots vs an unset field / default packetAlso, refactored to use the Vision timestamp directly instead of the robot timestamp.
Why
This makes it easier to reset the field in Sandbox Mode. It also lets us run sim with robots on just one team (eg: for tests that do not involve enemies)
Trying to do anything with 0 robots (like GC commands or plays) may lead to unexpected behavior, but I think it's reasonable to trust that the user won't be surprised by this.
Testing Done
Tested along with Sandbox Mode changes (#3815), specifically the Clear Field button. Works as expected and the field is cleared.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue