Sync Sandbox Mode across FullSystems#3839
Open
sauravbanna wants to merge 23 commits into
Open
Conversation
…ravbanna/sandbox_sidebar
…ravbanna/sandbox_sidebar
…mode enable to the sidebar checkbox + add toolbar indicator for sandbox state
…nment dynamic based on least index if assigned goalie not present + fixed bug with paused sim graphic repainting + block removing last robot
… coords. added check + inversion skip for yellow team
…ravbanna/sandbox_sidebar
…box state proto to be used
…+ added UI to choose which team to add robots to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the changes in Sandbox Mode can only be made per FullSystem. That is, blue robots can only be edited on Blue FS and vice versa. This means the user has to switch tabs to edit the whole field.
This PR lets the user edit all robots regardless of FullSystem tab. Local changes when sim is paused are also synced across tabs.
Testing Done
Builds fine. Tested basic Sandbox mode functions for both teams on both FS tabs.
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue