Skip to content

Update cross compiler gcc version#3841

Merged
nycrat merged 3 commits into
masterfrom
avah/fix_cross_compilation_toolchain
Jul 5, 2026
Merged

Update cross compiler gcc version#3841
nycrat merged 3 commits into
masterfrom
avah/fix_cross_compilation_toolchain

Conversation

@nycrat

@nycrat nycrat commented Jul 5, 2026

Copy link
Copy Markdown
Member

Description

As a part of c++ 20/23 support in our robot software, we updated the cross compiler to use gcc 14.3.0. This has been done, but the gcc path has not been updated from 8.5.0 yet. Also, the cross compiler version is just implicitly whatever is on main on this repo: https://github.com/UBC-Thunderbots/Software-External-Dependencies which initially caused this bug. So, this PR also pins the cross compiler version to a specific commit so this doesn't fail in the future.

Testing Done

Resolved Issues

Resolves #3242

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

{
FilterStep step{
.prediction = FilterStep::Predict{},
.prediction = std::make_optional<FilterStep::Predict>(),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc 14.3.0 gives error without make_optional because it would call the default move constructor for Predict which has eigen matrices that are technically uninitialized.

@nycrat nycrat merged commit e038f1d into master Jul 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade GCC and support C++20/C++23 in build toolchains

3 participants