Update cross compiler gcc version#3841
Merged
Merged
Conversation
1 task
nycrat
commented
Jul 5, 2026
| { | ||
| FilterStep step{ | ||
| .prediction = FilterStep::Predict{}, | ||
| .prediction = std::make_optional<FilterStep::Predict>(), |
Member
Author
There was a problem hiding this comment.
gcc 14.3.0 gives error without make_optional because it would call the default move constructor for Predict which has eigen matrices that are technically uninitialized.
Andrewyx
approved these changes
Jul 5, 2026
GrayHoang
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a part of c++ 20/23 support in our robot software, we updated the cross compiler to use gcc 14.3.0. This has been done, but the gcc path has not been updated from 8.5.0 yet. Also, the cross compiler version is just implicitly whatever is on main on this repo: https://github.com/UBC-Thunderbots/Software-External-Dependencies which initially caused this bug. So, this PR also pins the cross compiler version to a specific commit so this doesn't fail in the future.
Testing Done
Resolved Issues
Resolves #3242
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue