Skip to content

Fix gamecontroller default network interface typo#3843

Open
nycrat wants to merge 1 commit into
UBC-Thunderbots:masterfrom
nycrat:avah/fix_gamecontroller_typo
Open

Fix gamecontroller default network interface typo#3843
nycrat wants to merge 1 commit into
UBC-Thunderbots:masterfrom
nycrat:avah/fix_gamecontroller_typo

Conversation

@nycrat

@nycrat nycrat commented Jul 5, 2026

Copy link
Copy Markdown
Member

Description

In #3840, the new helper function to get the default network interface has a typo where it returns the ip instead of the interface. This works for some reason on ethernet but not when on wifi. This PR is just this one line fix.

Testing Done

Ran code on both wifi and ethernet. Everything works

Resolved Issues

N/A

Length Justification and Key Files to Review

N/A

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant