fix(governance): include missing files across js-sdk, ucp, and .github rules - #65
Merged
carolinerg1 merged 1 commit intoSep 2, 2026
Conversation
ptiper
force-pushed
the
fix/js-sdk-rules-add-tests
branch
from
September 2, 2026 09:48
b6c943e to
956d17d
Compare
nicholasjameshall
approved these changes
Sep 2, 2026
carolinerg1
approved these changes
Sep 2, 2026
carolinerg1
merged commit Sep 2, 2026
0b8ec08
into
Universal-Commerce-Protocol:main
13 checks passed
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix governance rule omissions across repositories to ensure 100% coverage and avoid unexpected
fallbacktriggers (which require Governance Council approval):js-sdk(js-sdk-rules.yml): Addtests/**underinfra_and_tooling.patterns. Currently, modifying test files (such astests/spec-constraints.test.js) falls back to the catch-all rule.ucp(ucp-rules.yml): AddREADME.mdunderinfra_and_tooling.patterns(aligning with all other UCP repositories)..github(.github-rules.yml): AddDOMAIN_WORKING_GROUP_CHARTER.mdundergovernance.patternsalongsideDOMAIN_TECH_COUNCIL_CHARTER.md.With these updates, static coverage analysis (
validate_no_fallback) achieves 100% across all 8 active UCP repositories (966 tracked files scanned with 0 unhandled fallbacks).Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
None
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
Unit tests in
.github:No-fallback coverage check across all 8 repos (966 files total):
js-sdk: 0 fallback filespython-sdk: 0 fallback filesucp: 0 fallback filesucp-schema: 0 fallback filesconformance: 0 fallback filessamples: 0 fallback filesmeeting-minutes: 0 fallback files.github: 0 fallback files