fix(governance): add tests/** pattern to js-sdk infra_and_tooling rule - #67
Closed
carolinerg1 wants to merge 1 commit into
Closed
fix(governance): add tests/** pattern to js-sdk infra_and_tooling rule#67carolinerg1 wants to merge 1 commit into
carolinerg1 wants to merge 1 commit into
Conversation
Contributor
Author
|
Duplicate of #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Pull requests in
js-sdkmodifying test files (such astests/spec-constraints.test.js) fall back to thegovernance-councilrule becausetests/**was omitted frominfra_and_toolingpatterns injs-sdk-rules.yml. This causes PRs with maintainer/devops approvals to fail governance validation withINSUFFICIENT_APPROVALS.Fix
Add
tests/**toinfra_and_toolingpatterns injs-sdk-rules.ymlto align withpython-sdk-rules.yml.Category (Required)
Related Issues
None
Checklist
generate_models.shunderpython_sdk.