Skip to content

fix(governance): add tests/** pattern to js-sdk infra_and_tooling rule - #67

Closed
carolinerg1 wants to merge 1 commit into
mainfrom
fix/js-sdk-rules-test-pattern
Closed

fix(governance): add tests/** pattern to js-sdk infra_and_tooling rule#67
carolinerg1 wants to merge 1 commit into
mainfrom
fix/js-sdk-rules-test-pattern

Conversation

@carolinerg1

@carolinerg1 carolinerg1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Problem

Pull requests in js-sdk modifying test files (such as tests/spec-constraints.test.js) fall back to the governance-council rule because tests/** was omitted from infra_and_tooling patterns in js-sdk-rules.yml. This causes PRs with maintainer/devops approvals to fail governance validation with INSUFFICIENT_APPROVALS.

Fix

Add tests/** to infra_and_tooling patterns in js-sdk-rules.yml to align with python-sdk-rules.yml.

Category (Required)

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Related Issues

None

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

@carolinerg1

Copy link
Copy Markdown
Contributor Author

Duplicate of #65

@carolinerg1 carolinerg1 marked this as a duplicate of #65 Sep 2, 2026
@carolinerg1 carolinerg1 closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant