Skip to content

feat(nodes): Add c37.118 node-type with WITH_NODE_C37_118 build option - #1047

Merged
steffen-vogel-opalrt merged 1 commit into
VILLASframework:masterfrom
leonardocarreras:fix/c37-118-build-option
Aug 3, 2026
Merged

feat(nodes): Add c37.118 node-type with WITH_NODE_C37_118 build option#1047
steffen-vogel-opalrt merged 1 commit into
VILLASframework:masterfrom
leonardocarreras:fix/c37-118-build-option

Conversation

@leonardocarreras

@leonardocarreras leonardocarreras commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Disclaimer: the title should be (fix) but I deliverately picked (feat) to make release-please to know that the node was there, the actual feat is #1023 (merged), so will get a correct minor bump

What it actually does here:

  • Create the option for building with/without WITH_NODE_C37_118
  • Wire the test and the skip message
  • Add checks for netdb and poll, it might need some comments from the original creator @pjungkamp to see if this is the correct way

Closes #1046 and will help with #1045

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
@steffen-vogel-opalrt

Copy link
Copy Markdown
Contributor

LGTM

@steffen-vogel-opalrt
steffen-vogel-opalrt merged commit b87d6b4 into VILLASframework:master Aug 3, 2026
55 checks passed
@pjungkamp

Copy link
Copy Markdown
Contributor

I don't agree with the checks for poll.h and netdb.h.

poll.h is unconditionally required our path implementations which is non-optional. The netdb.h header is required for e.g the socket and rtp node-types (among others).

But even more importantly, why would header checks for POSIX headers even be necessary? Is there any system we want to support where those could be not available? And adding these checks for all POSIX headers (e.g. pthreads) doesn't seem desireable. I'd consider it bloat in our build system.

@leonardocarreras
leonardocarreras deleted the fix/c37-118-build-option branch August 4, 2026 08:21
@leonardocarreras

Copy link
Copy Markdown
Contributor Author

@pjungkamp thanks for the reply.

Agree on the view regarding the checks.

As a bit of context, I am experimenting with an MSVC build of a minimal non-POSIX subset, but we can deal with that in a different way (maybe _MSC_VER). That is still not in-tree, so I could open a PR to delete the checks, if that would be preferable for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node compiles unconditionally for C37.118

3 participants