feat(nodes): Add c37.118 node-type with WITH_NODE_C37_118 build option - #1047
Conversation
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
|
LGTM |
|
I don't agree with the checks for
But even more importantly, why would header checks for POSIX headers even be necessary? Is there any system we want to support where those could be not available? And adding these checks for all POSIX headers (e.g. pthreads) doesn't seem desireable. I'd consider it bloat in our build system. |
|
@pjungkamp thanks for the reply. Agree on the view regarding the checks. As a bit of context, I am experimenting with an MSVC build of a minimal non-POSIX subset, but we can deal with that in a different way (maybe |
Disclaimer: the title should be (fix) but I deliverately picked (feat) to make release-please to know that the node was there, the actual feat is #1023 (merged), so will get a correct minor bump
What it actually does here:
Closes #1046 and will help with #1045