Fix sample compare for timestamps - #1052
Merged
Merged
Conversation
windrad6
force-pushed
the
fix-sample-compare
branch
from
September 4, 2026 12:23
7d8c93e to
8fd68da
Compare
Contributor
Author
|
Some node integration tests use the signal generator as input and therefor the timestamps are not comparable to the expected values. |
pjungkamp
approved these changes
Sep 4, 2026
windrad6
enabled auto-merge (rebase)
September 6, 2026 10:50
Contributor
|
Looks good. Could you explain what motivated this change? Didnt our tests pass before as well? |
stv0g
approved these changes
Sep 7, 2026
added 2 commits
September 7, 2026 21:30
Signed-off-by: Manuel <post@cl0.de>
Signed-off-by: Manuel <post@cl0.de>
stv0g
force-pushed
the
fix-sample-compare
branch
from
September 7, 2026 19:30
31cfb81 to
ead5485
Compare
stv0g
disabled auto-merge
September 7, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample time compare only compared for a positive time diff. Now changed to an abs compare.