Skip to content

Fix sample compare for timestamps #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stv0g merged 2 commits into from
Sep 7, 2026
Merged

Fix sample compare for timestamps #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
832841a
fix(sample): Change ts compare to absolute compare
Sep 4, 2026
ead5485
test(nodes): Change integration test to ignore timestamps in compare
Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sample.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ int villas::node::sample_cmp(struct Sample *a, struct Sample *b, double epsilon,

// Compare timestamp
if (flags & (int)SampleFlags::HAS_TS_ORIGIN) {
if (time_delta(&a->ts.origin, &b->ts.origin) > epsilon) {
if (abs(time_delta(&a->ts.origin, &b->ts.origin)) > epsilon) {
printf("ts.origin: %f != %f\n", time_to_double(&a->ts.origin),
time_to_double(&b->ts.origin));
return 3;
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/node-hook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@ EOF

villas node config.json

villas compare output.dat expect.dat
villas compare -T output.dat expect.dat
2 changes: 1 addition & 1 deletion tests/integration/node-mapping.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,4 @@ EOF

villas node -d debug config.json

villas compare output.dat expect.dat
villas compare -T output.dat expect.dat
2 changes: 1 addition & 1 deletion tests/integration/node-multiplexing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ EOF

villas node config.json

villas compare output.dat expect_${MODE}.dat
villas compare -T output.dat expect_${MODE}.dat

rm output.dat

Expand Down
Loading