docs: remove directory upload/download endpoints and update default bind address#49
Merged
Merged
Conversation
The antd daemon now binds to 127.0.0.1 by default on both REST (8082) and gRPC (50051). The /v1/dirs/upload/public and /v1/dirs/download/public REST endpoints have been removed, along with the DirUploadPublic and DirDownloadPublic gRPC RPCs. The MCP server's upload_file and download_file tools no longer accept an is_directory parameter. Verified against ant-sdk@4021000b552175394bcfe04f1c7712467887d539.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
a3cf4e40→4021000b—feat(antd)!: bind to 127.0.0.1 by default on REST and gRPC (#107)Source artifacts inspected
antd/openapi.yaml— removedPOST /v1/dirs/upload/publicandPOST /v1/dirs/download/publicendpoints andDirUploadPublicResponseschemaantd/proto/antd/v1/files.proto— removedDirUploadPublicandDirDownloadPublicRPCs fromFileServiceantd/proto/antd/v1/common.proto— removedGraphDescendantmessageantd/src/config.rs— defaultrest_addrchanged from0.0.0.0:8082to127.0.0.1:8082; defaultgrpc_addrchanged from0.0.0.0:50051to127.0.0.1:50051antd-go/client.go,antd-go/grpc_client.go—DirUploadPublicandDirDownloadPublicmethods removedantd-mcp/src/antd_mcp/server.py—is_directoryparameter removed fromupload_fileanddownload_filetoolsantd/README.md— updated default address table and added Security defaults sectionDeveloper-facing change
The
antddaemon now binds to127.0.0.1(loopback) by default on both REST (8082) and gRPC (50051). Pass0.0.0.0:8082explicitly to expose on the network. ThePOST /v1/dirs/upload/publicandPOST /v1/dirs/download/publicREST endpoints have been removed, along with theDirUploadPublicandDirDownloadPublicgRPC RPCs and their corresponding methods in all language binding clients. The MCP server'supload_fileanddownload_filetools no longer accept anis_directoryparameter.Files changed in this PR
docs/sdk/reference/rest-api.md— removed "Upload a Public Directory" and "Download a Public Directory" sections; renamed "Files and directories" section to "Files"docs/sdk/reference/grpc-services.md— removed "Upload Public Directory" and "Download Public Directory" subsections from File Servicedocs/sdk/reference/daemon-command-reference.md— updated default values for--rest-addrand--grpc-addrto127.0.0.1; updated example to show opting in to network exposuredocs/sdk/reference/overview.md— updated route table row to remove directory routesdocs/sdk/how-to-guides/store-and-retrieve-data.md— removed "6. Upload and download a directory" step; updated intro and verify section to remove directory referencesdocs/mcp/mcp-server-reference.md— removedis_directoryparameter fromupload_fileanddownload_filetool signatures and descriptionsWhy prose changed
--rest-addris now127.0.0.1:8082(was0.0.0.0:8082) and--grpc-addris127.0.0.1:50051(was0.0.0.0:50051) perantd/src/config.rsat4021000b.POST /v1/dirs/upload/publicandPOST /v1/dirs/download/publicare absent fromantd/openapi.yamlat4021000b.DirUploadPublicandDirDownloadPublicRPCs are absent fromantd/proto/antd/v1/files.protoat4021000b.upload_fileanddownload_filetool signatures no longer includeis_directoryperantd-mcp/src/antd_mcp/server.pyat4021000b.Verification run
python3 scripts/sweep_poll.pyon prose branch: statusok, all 6 prose pages showdrifted: falsefor ant-sdk after SHA refresh./v1/dirs/upload/public,/v1/dirs/download/public,DirUploadPublic,DirDownloadPublic,dir_upload_public,dirUploadPublic,is_directorydo not appear in any docs page after edit.127.0.0.1:8082and127.0.0.1:50051inantd/src/config.rsat4021000b.POST /v1/files/upload/publicstill present inantd/openapi.yamlat4021000b(file endpoint retained).node --check: not applicable (no JS code samples changed).Uncertainties
The
GraphDescendantproto message was also removed fromantd/proto/antd/v1/common.protoat4021000b. No existing docs page documentedGraphDescendantas a standalone type, so no prose change was required. Reviewer should confirm there is no Graph data type reference page elsewhere in the docs that was missed.Generated by Claude Code