Skip to content

docs: remove directory upload/download endpoints and update default bind address#49

Merged
JimCollinson merged 3 commits into
mainfrom
claude/prose-2026-05-21-dir-removal
May 21, 2026
Merged

docs: remove directory upload/download endpoints and update default bind address#49
JimCollinson merged 3 commits into
mainfrom
claude/prose-2026-05-21-dir-removal

Conversation

@JimCollinson
Copy link
Copy Markdown
Collaborator

Upstream

  • ant-sdk: a3cf4e404021000bfeat(antd)!: bind to 127.0.0.1 by default on REST and gRPC (#107)

Source artifacts inspected

  • antd/openapi.yaml — removed POST /v1/dirs/upload/public and POST /v1/dirs/download/public endpoints and DirUploadPublicResponse schema
  • antd/proto/antd/v1/files.proto — removed DirUploadPublic and DirDownloadPublic RPCs from FileService
  • antd/proto/antd/v1/common.proto — removed GraphDescendant message
  • antd/src/config.rs — default rest_addr changed from 0.0.0.0:8082 to 127.0.0.1:8082; default grpc_addr changed from 0.0.0.0:50051 to 127.0.0.1:50051
  • antd-go/client.go, antd-go/grpc_client.goDirUploadPublic and DirDownloadPublic methods removed
  • antd-mcp/src/antd_mcp/server.pyis_directory parameter removed from upload_file and download_file tools
  • antd/README.md — updated default address table and added Security defaults section

Developer-facing change

The antd daemon now binds to 127.0.0.1 (loopback) by default on both REST (8082) and gRPC (50051). Pass 0.0.0.0:8082 explicitly to expose on the network. The POST /v1/dirs/upload/public and POST /v1/dirs/download/public REST endpoints have been removed, along with the DirUploadPublic and DirDownloadPublic gRPC RPCs and their corresponding methods in all language binding clients. The MCP server's upload_file and download_file tools no longer accept an is_directory parameter.

Files changed in this PR

  • docs/sdk/reference/rest-api.md — removed "Upload a Public Directory" and "Download a Public Directory" sections; renamed "Files and directories" section to "Files"
  • docs/sdk/reference/grpc-services.md — removed "Upload Public Directory" and "Download Public Directory" subsections from File Service
  • docs/sdk/reference/daemon-command-reference.md — updated default values for --rest-addr and --grpc-addr to 127.0.0.1; updated example to show opting in to network exposure
  • docs/sdk/reference/overview.md — updated route table row to remove directory routes
  • docs/sdk/how-to-guides/store-and-retrieve-data.md — removed "6. Upload and download a directory" step; updated intro and verify section to remove directory references
  • docs/mcp/mcp-server-reference.md — removed is_directory parameter from upload_file and download_file tool signatures and descriptions

Why prose changed

  • daemon-command-reference.md: Default --rest-addr is now 127.0.0.1:8082 (was 0.0.0.0:8082) and --grpc-addr is 127.0.0.1:50051 (was 0.0.0.0:50051) per antd/src/config.rs at 4021000b.
  • rest-api.md: POST /v1/dirs/upload/public and POST /v1/dirs/download/public are absent from antd/openapi.yaml at 4021000b.
  • grpc-services.md: DirUploadPublic and DirDownloadPublic RPCs are absent from antd/proto/antd/v1/files.proto at 4021000b.
  • overview.md: The route table listed the now-removed directory routes.
  • store-and-retrieve-data.md: The guide included a step for directory upload/download using the removed endpoints and binding methods.
  • mcp-server-reference.md: upload_file and download_file tool signatures no longer include is_directory per antd-mcp/src/antd_mcp/server.py at 4021000b.

Verification run

  • python3 scripts/sweep_poll.py on prose branch: status ok, all 6 prose pages show drifted: false for ant-sdk after SHA refresh.
  • Confirmed /v1/dirs/upload/public, /v1/dirs/download/public, DirUploadPublic, DirDownloadPublic, dir_upload_public, dirUploadPublic, is_directory do not appear in any docs page after edit.
  • Confirmed default addresses 127.0.0.1:8082 and 127.0.0.1:50051 in antd/src/config.rs at 4021000b.
  • Confirmed POST /v1/files/upload/public still present in antd/openapi.yaml at 4021000b (file endpoint retained).
  • markdownlint: not configured in repo — skipped.
  • node --check: not applicable (no JS code samples changed).

Uncertainties

The GraphDescendant proto message was also removed from antd/proto/antd/v1/common.proto at 4021000b. No existing docs page documented GraphDescendant as a standalone type, so no prose change was required. Reviewer should confirm there is no Graph data type reference page elsewhere in the docs that was missed.


Generated by Claude Code

claude and others added 3 commits May 21, 2026 13:52
The antd daemon now binds to 127.0.0.1 by default on both REST (8082)
and gRPC (50051). The /v1/dirs/upload/public and /v1/dirs/download/public
REST endpoints have been removed, along with the DirUploadPublic and
DirDownloadPublic gRPC RPCs. The MCP server's upload_file and download_file
tools no longer accept an is_directory parameter.

Verified against ant-sdk@4021000b552175394bcfe04f1c7712467887d539.
@JimCollinson JimCollinson marked this pull request as ready for review May 21, 2026 15:53
@JimCollinson JimCollinson merged commit bdb06cf into main May 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants