fix(desktop): route overlays on shadow-nous + ladder rungs, single scrim source - #4
Conversation
…rim source - overlay-view: z-50 literal + bg-black/22 blur -> z-(--z-route-overlay-backdrop) + scrim-nous; card shadow-md + --ui-stroke-secondary -> shadow-nous + --stroke-nous (DESIGN.md floating-panel contract) - styles.css: new ladder rungs --z-route-overlay-backdrop:100 / --z-route-overlay:110 (below dialogs); --ui-scrim token + @Utility scrim-nous as the single dim/blur source - dialog/sheet/session-picker: replace duplicated bg-black/22 backdrop-blur-[0.125rem] copies with scrim-nous; sheet z-50 -> --z-modal-backdrop/--z-modal rungs - DESIGN.md: document scrim-nous, --ui-scrim, route-overlay rungs
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
…#6) Second pass of the DESIGN.md overlay-ladder audit (first pass: OverlayView, PR #4). Ported menus and popovers off the z-50 literal onto the z ladder: - context-menu.tsx / dropdown-menu.tsx / popover.tsx (Radix primitives, portaled to body): z-50 -> z-(--z-modal-popover) (140) - starmap/node-context-menu.tsx: backdrop -> z-(--z-modal-backdrop), menu -> z-(--z-modal-popover) - find-bar.tsx (fixed command surface): z-50 -> z-(--z-over-modal) (200) Remaining z-50 are local in-component stacking (tree drop targets with documented intent, composer/terminal overlays) — allowed by DESIGN.md ('plain z-10/z-20 for stacking within one component'). Verification: tsc 0 new errors (5 pre-existing frimousse dep errors), eslint 0, vitest 60/60 (find-bar 48, no-native-title, starmap share).
O que foi feito
Correção de conformidade com o contrato de design (
apps/desktop/DESIGN.md) identificada em auditoria:z-50literal +bg-black/22+shadow-md+border-(--ui-stroke-secondary). Agora usaz-(--z-route-overlay-backdrop)+scrim-nousno backdrop eshadow-nous+border-(--stroke-nous)no card — o tratamento de floating panel exigido pelo DESIGN.md.--z-route-overlay-backdrop:100/--z-route-overlay:110emstyles.css, abaixo de--z-modal-backdrop:120(route overlays ficam sob dialogs, que abrem por cima).--ui-scrim(color-mix #000 22%) +@utility scrim-nous(fill + blur 0.125rem) substituem as 4 cópias debg-black/22 backdrop-blur-[0.125rem]em dialog.tsx, sheet.tsx, overlay-view.tsx e session-picker.tsx (que tinha bg-black/15 blur 1px — agora unificado em 22%/0.125rem).z-50→z-(--z-modal-backdrop)/z-(--z-modal)(rungs corretos de modal).scrim-nous,--ui-scrime os rungs de route overlay.Verificação
tsc -p . --noEmit— 0 erroseslintnos 4 arquivos alterados — 0 errosvitest(dialog, dialog-dismiss-repro, panel, no-native-title) — 9/9 passandoz-50restantes nos overlays corrigidos; zero cópias debg-black/22fora de styles.cssArquivos
apps/desktop/src/app/overlays/overlay-view.tsxapps/desktop/src/components/ui/dialog.tsxapps/desktop/src/components/ui/sheet.tsxapps/desktop/src/components/session-picker.tsxapps/desktop/src/styles.cssapps/desktop/DESIGN.md6 arquivos, +33/-11.
Summary by cubic
Aligns desktop route overlays and sheets with the design contract. Fixes stacking under dialogs and centralizes the dim/blur layer.
z-(--z-route-overlay-backdrop)+scrim-nousfor the backdrop andshadow-nous+--stroke-nousfor the card (replacesz-50,bg-black/22,shadow-md).--z-route-overlay-backdrop:100and--z-route-overlay:110under modal rungs; sheets move to--z-modal-backdrop/--z-modal.--ui-scrimtoken andscrim-nousutility replace duplicated scrim styles in dialog, sheet, overlay, and session picker (22% black + 0.125rem blur).Written for commit b0edcd5. Summary will update on new commits.