chore(deps): use php 8.5 by default#1
Conversation
aegypius
force-pushed
the
chores/php-8.4
branch
2 times, most recently
from
936acd1 to
395be52
Compare
aegypius
force-pushed
the
chores/php-8.4
branch
from
395be52 to
97d7200
Compare
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project to use PHP 8.4 as the default version and updates several development dependencies to more specific versions. The changes include refactoring the Dagger CI setup to dynamically detect the PHP version from composer.json instead of hardcoding it, and improving the GitHub Actions workflow configuration.
Changes:
- Upgraded PHP requirement from ^8.3 to ^8.4 in composer.json
- Updated development dependencies to more specific versions (PHPStan, PHPUnit, ECS, etc.)
- Refactored .dagger/src/PhpProject.php to dynamically detect PHP version from composer.json
- Enhanced GitHub Actions workflow to trigger on pull requests and fixed incorrect step name
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| composer.json | Updates PHP version requirement to ^8.4, pins dev dependencies to specific versions, and adds bump-after-update config |
| .github/workflows/continuous-integration.yaml | Adds pull_request trigger and fixes step name in test job |
| .dagger/src/PhpProject.php | Introduces dynamic PHP version detection to replace hardcoded version in container images |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…on cache (#2) Co-authored-by: aegypius <25710+aegypius@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: aegypius <25710+aegypius@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aegypius
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return $this->php() | ||
| ->withMountedDirectory("/app", $source) | ||
| ->withDirectory("/app/vendor", $this->vendors($source)) |
There was a problem hiding this comment.
checkCodingStandards() now runs on PHP 8.5 via $this->php(), but vendors() still installs dependencies in a separate composer:2 container. Since the root composer.json now requires PHP ^8.5, dependency installation can become non-deterministic (and potentially fail) if the composer:2 image is built on a lower PHP version. Consider aligning dependency installation with the same PHP version (e.g., run Composer inside the PHP 8.5 container or pin to a Composer image/tag that is guaranteed to use PHP 8.5).
No description provided.