-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): use php 8.5 by default #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0d5f81a
5b2a794
97d7200
926186a
fe6f891
aa50151
35b7cdb
0f1a6f5
bc58448
6bee575
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,27 @@ | |
| #[Doc("PHP Code Quality functions")] | ||
| class PhpProject | ||
| { | ||
| /** | ||
| * Create a PHP container using the specified image and variant. | ||
| * | ||
| * This method constructs a container from the given PHP image name and | ||
| * variant. By default, it uses the "php:8.5-cli" image. It does not perform | ||
| * any automatic PHP version detection or caching. | ||
| * | ||
| * @param string $image The base PHP image name (default: "php") | ||
| * @param string $variant The PHP image variant tag (default: "8.5-cli") | ||
| * @return Container A container based on the specified PHP image | ||
| */ | ||
| private function php( | ||
| string $image = "php", | ||
| string $variant = "8.5-cli", | ||
| ): Container { | ||
|
aegypius marked this conversation as resolved.
|
||
| return dag() | ||
| ->container() | ||
| ->from("{$image}:{$variant}") | ||
| ; | ||
| } | ||
|
aegypius marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Allows to install vendors with | ||
| * | ||
|
|
@@ -48,9 +69,7 @@ public function checkCodingStandards( | |
| #[DefaultPath("."), Ignore("**/vendor", "docs")] | ||
| Directory $source | ||
| ): Container { | ||
| return dag() | ||
| ->container() | ||
| ->from("php:8.3-cli") | ||
| return $this->php() | ||
| ->withMountedDirectory("/app", $source) | ||
| ->withDirectory("/app/vendor", $this->vendors($source)) | ||
|
Comment on lines
+72
to
74
|
||
| ->withWorkdir("/app") | ||
|
|
@@ -74,9 +93,7 @@ public function test( | |
| $phpunit[] = "--testsuite={$testSuite}"; | ||
| } | ||
|
|
||
| return dag() | ||
| ->container() | ||
| ->from("php:8.3-cli") | ||
| return $this->php() | ||
| ->withMountedDirectory("/app", $source) | ||
| ->withDirectory("/app/vendor", $this->vendors($source)) | ||
| ->withWorkdir("/app") | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.