chore(ui): remove unused badgeVariants export#227
Open
andrerfneves wants to merge 1 commit into
Open
Conversation
badgeVariants is a CVA variant definition used internally by the Badge component, but it is never imported by any other file in the project. Removing it from the export list keeps the public API surface minimal and consistent with similar cleanup PRs (dialog, dropdown-menu, sheet components). This is consistent with existing cleanup PRs: - #213, #207, #203 (dialog) - #201 (dropdown-menu) - #200 (sheet)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
badgeVariantsexport from thebadge.tsxshadcn/ui component.Why
badgeVariantsis a CVA variant definition used internally by theBadgecomponent viabadgeVariants({ variant })andVariantProps<typeof badgeVariants>, but it is never imported by any other file in the project.This is consistent with the established cleanup pattern in the repository:
dialog.tsx(DialogFooter,DialogPortal,DialogOverlay,DialogClose,DialogTrigger)dropdown-menu.tsxsheet.tsx(SheetPortal,SheetOverlay)Changes
src/components/ui/badge.tsx: Changedexport { Badge, badgeVariants }→export { Badge }The
badgeVariantsvariable and theBadgePropsinterface remain in the file since they are used internally by theBadgecomponent.Test Plan
badgeVariantsis unchanged