Skip to content

[ISSUE #10829] fix(common): handle negative version values #10839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuluo-yx wants to merge 1 commit into
base: develop
Choose a base branch
from
+17 −1
Open

[ISSUE #10829] fix(common): handle negative version values #10839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions common/src/main/java/org/apache/rocketmq/common/MQVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ public class MQVersion {
public static String getVersionDesc(int value) {
Version[] versions = VERSION_VALUES;
int length = versions.length;
if (value < 0) {
return versions[0].name();
}
if (value >= length) {
return versions[length - 1].name();
}
Expand All @@ -34,6 +37,9 @@ public static String getVersionDesc(int value) {
public static Version value2Version(int value) {
Version[] versions = VERSION_VALUES;
int length = versions.length;
if (value < 0) {
return versions[0];
}
if (value >= length) {
return versions[length - 1];
}
Expand Down
12 changes: 11 additions & 1 deletion common/src/test/java/org/apache/rocketmq/common/MQVersionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ public void testGetVersionDesc_higherVersion() throws Exception {
assertThat(MQVersion.getVersionDesc(Integer.MAX_VALUE)).isEqualTo(desc);
}

@Test
public void testGetVersionDesc_NegativeVersion() {
assertThat(MQVersion.getVersionDesc(-1)).isEqualTo("V3_0_0_SNAPSHOT");
}

@Test
public void testValue2Version() throws Exception {
assertThat(MQVersion.value2Version(0)).isEqualTo(MQVersion.Version.V3_0_0_SNAPSHOT);
Expand All @@ -44,4 +49,9 @@ public void testValue2Version() throws Exception {
public void testValue2Version_HigherVersion() throws Exception {
assertThat(MQVersion.value2Version(Integer.MAX_VALUE)).isEqualTo(MQVersion.Version.HIGHER_VERSION);
}
}

@Test
public void testValue2Version_NegativeVersion() {
assertThat(MQVersion.value2Version(-1)).isEqualTo(MQVersion.Version.V3_0_0_SNAPSHOT);
}
}
Loading