ci: populate manifest on every release build + record migration tarball URL#516
Merged
Merged
Conversation
33fd512 to
dd8256f
Compare
Collaborator
Author
|
Two fixes pushed after self-review:
|
…cord migration tarball URL
dd8256f to
a08874a
Compare
Collaborator
Author
|
Two more fixes from review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #514/#515. Makes the Release workflow feed the update manifest, and adds robustness.
1. Manifest is populated on every build, including fork-source builds. The "Update generated manifest branch" step was
same-repo-guarded, sosource_repository-driven builds (the current way we buildmrosseel:nixos) published assets but never recorded a manifest entry — sosoftware.py's channel UI never saw the release. Now the release job checks out the base repo (for the trusted manifest scripts + correct pushorigin), takes the built source SHA from the build job, and always runs the manifest step.2. Manifest release entries now carry the migration tarball. Added
migration_url+migration_sha256_urltoupdate_manifest.pyrelease entries (pointing at this repo's release assets). This lets the migration path select a release from the manifest (stable→beta→unstable) instead of a hardcoded URL — companion app-side change to follow.3. Fix image-artifact corruption when both builders run. If the native build is slow,
native-waittimes out and the hosted fallback also runs; both upload an identically-named.img.zst. The olddownload-artifact … merge-multiplemerged them →zstd"Data corruption detected" (this failed the v3.0.0-beta run). Now native/hosted images download to separate dirs and the assemble step prefers native.Validated with actionlint (only the known self-hosted-label warning) and py_compile.
🤖 Generated with Claude Code