fix(makefile): make pa11y-install idempotent - #627
Merged
Conversation
bepri
requested review from
SecondSkoll,
a-velasco,
akcano,
dwilding,
medubelko,
rkratky and
tang-mm
as code owners
August 19, 2026 13:12
dwilding
approved these changes
Aug 20, 2026
dwilding
left a comment
dwilding
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Please could you update CHANGES.md with a quick description of the fix and list this PR number after docs/Makefile - very similar to what https://github.com/canonical/sphinx-stack/pull/628/changes does.
jahn-junior
approved these changes
Aug 20, 2026
jahn-junior
left a comment
jahn-junior
left a comment
Collaborator
There was a problem hiding this comment.
TIL that this is platform-dependent. The original command -v target works fine on my machine, but test -x is nicer regardless.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdwith relevant non-documentation file changes?Fixes an issue where the
pa11y-installtarget would always trigger a reinstall, even if pa11y was already available.Tested the output locally by changing the
pa11y-installtarget toecho $(firstword $(PA11Y_CMD)), which output_dev/node_modules/pa11y/bin/pa11y.js.