Skip to content

fix(makefile): make pa11y-install idempotent #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahn-junior merged 4 commits into from
Aug 20, 2026
Merged

fix(makefile): make pa11y-install idempotent #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f143bc5
fix(makefile): make pa11y-install idempotent
bepri Aug 19, 2026
e7e518a
docs: add changelog entry
bepri Aug 20, 2026
5cd9448
chore: use test instead of command
bepri Aug 20, 2026
5c42035
docs: fix changelog
jahn-junior Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@
* Make removed URL check redirect-aware and add support for reusable workflow contexts
* Exclude utility directories from builds and checks
* Update link to documentation in README
* Skip pa11y installation if it is already present

### Changed

* `docs/conf.py` [#610](https://github.com/canonical/sphinx-stack/pull/610)
* `docs/Makefile` [#605](https://github.com/canonical/sphinx-stack/pull/605), [#610](https://github.com/canonical/sphinx-stack/pull/610)
* `docs/Makefile` [#605](https://github.com/canonical/sphinx-stack/pull/605), [#610](https://github.com/canonical/sphinx-stack/pull/610), [#627](https://github.com/canonical/sphinx-stack/pull/627)
* `README.md` [#603](https://github.com/canonical/sphinx-stack/pull/603)
* `.github/workflows/cla-check.yml` [#606](https://github.com/canonical/sphinx-stack/pull/606)
* `.github/workflows/check-removed-urls.yml` [#612](https://github.com/canonical/sphinx-stack/pull/#612)
Expand Down
2 changes: 1 addition & 1 deletion docs/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ $(DOCS_VENVDIR):
@touch $(DOCS_VENVDIR)

pa11y-install:
@command -v $(PA11Y_CMD) >/dev/null || { \
@test -x $(firstword $(PA11Y_CMD)) >/dev/null || { \
echo "Installing \"pa11y\" from npm..."; echo; \
mkdir -p $(DEV_DIR)/node_modules/ ; \
npm install --prefix $(DEV_DIR) pa11y; \
Expand Down
Loading