fix(files,terminal): one path and shell-syntax contract on every OS - #146
Merged
Merged
Conversation
Local file paths now collapse either separator to a slash path before os.Root and path.Match, so a Windows separator is not an escape. Bash detects operators before tokenization instead of dropping them. Virtual mounts can sit on a path prefix such as cyber://skills/.
Parse the script instead of guessing operators from argv. Windows uses a Win32 bash when one is installed, and a pipe in a kill-on-close job so the console cannot rewrite output and cancel still stops MSYS children.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.and duplicates, and keep a single/namespace.path.Matchtreats\as an escape on every OS, andos.Rootwants slash paths.Absolute workdir joining for a remote runner stays in Cairn. The server is not the runner's OS.
Test plan
go test -count=1 ./tools/terminal/ ./tools/files/ ./core/tool/ ./pkg/exts/files/ ./pkg/exts/prompt/memory_echo one&&memory_echo tworuns both;'a;b'and a quoted empty argument stay argumentssleepdoes not run the rest of the line