Skip to content

fix(shell): finish commands when code cells are killed - #193

Merged
clabby merged 1 commit into
cl/release-0.6.7from
cl/shell-kill-cleanup
Aug 29, 2026
Merged

fix(shell): finish commands when code cells are killed#193
clabby merged 1 commit into
cl/release-0.6.7from
cl/shell-kill-cleanup

Conversation

@clabby

@clabby clabby commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • associate yielded code-mode cell IDs with their original transcript workflow
  • when a wait confirms Script terminated, fail that cell's unfinished nested tools and clear their running shell bookkeeping
  • retain cell ownership across nonterminal failed waits, including Nanocodex's observer-busy Script failed response
  • add regression coverage for a failed wait followed by termination of an unfinished shell command

Testing

  • cargo test -p tact tui::transcript::model::tests
  • just check-fmt
  • cargo check
  • just clippy

Stack

Depends on #191.

@clabby clabby changed the title cl/shell kill cleanup fix(shell): finish commands when code cells are killed Aug 29, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 18 untouched benchmarks
⏩ 31 skipped benchmarks1


Comparing cl/shell-kill-cleanup (d11219a) with cl/release-0.6.7 (fb706ab)

Open in CodSpeed

Footnotes

  1. 31 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@clabby
clabby merged commit 344ffeb into main Aug 29, 2026
16 checks passed
@clabby
clabby deleted the cl/shell-kill-cleanup branch August 29, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant