Skip to content

Bug: Initialize settings in configured workflow task executor - #176

Merged
nthmost-orkes merged 2 commits into
conductor-oss:mainfrom
Robban1980:feature/initialize-workflow-task-executor-settings
Sep 11, 2026
Merged

Bug: Initialize settings in configured workflow task executor#176
nthmost-orkes merged 2 commits into
conductor-oss:mainfrom
Robban1980:feature/initialize-workflow-task-executor-settings

Conversation

@Robban1980

Copy link
Copy Markdown
Contributor

Summary

Fixes WorkflowTaskExecutor when it is created with an explicit WorkflowTaskExecutorConfiguration.

The configured constructor did not initialize _workerSettings, causing a null-reference failure when the executor starts or polls for tasks.

Changes

  • Initialize _workerSettings from the supplied configuration.
  • Fall back to worker.WorkerSettings when no explicit configuration is supplied.
  • Add regression coverage for both explicit and fallback configuration paths.

Validation

The new tests verify that polling uses the expected worker ID, domain, and requested task count for both configuration paths.

@Robban1980

Copy link
Copy Markdown
Contributor Author

This PR’s integration_tests_oss job reads its image tag from the organization Actions variable E2E_TEST_OSS_CONDUCTOR_VERSION.

In the failing run, that variable resolves to empty, so the job exits before its generated docker-compose-oss.yaml exists. Could an org owner set the variable and grant conductor-oss/csharp-sdk access?

The PR does not need a code change to supply the value, but I updated the failure-log guard so the missing-variable error is no longer obscured by the follow-up compose-file message.

@Robban1980

Copy link
Copy Markdown
Contributor Author

Any update?

@chrishagglund-ship-it

chrishagglund-ship-it commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

We have merged a change into the main branch that will set a default oss conductor image version to use in situations where the org variable cannot be resolved. I think a new commit or needs to be pushed in this branch to get the CI run to use the latest main workflow, because just re-running it doesn't seem to be picking up the upstream fix.

@Robban1980

Copy link
Copy Markdown
Contributor Author

@chrishagglund-ship-it i synced my branch with the current main, let's see if this will work.

@nthmost-orkes
nthmost-orkes merged commit baee784 into conductor-oss:main Sep 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants