Bug: Initialize settings in configured workflow task executor - #176
Conversation
|
This PR’s integration_tests_oss job reads its image tag from the organization Actions variable In the failing run, that variable resolves to empty, so the job exits before its generated docker-compose-oss.yaml exists. Could an org owner set the variable and grant conductor-oss/csharp-sdk access? The PR does not need a code change to supply the value, but I updated the failure-log guard so the missing-variable error is no longer obscured by the follow-up compose-file message. |
|
Any update? |
|
We have merged a change into the main branch that will set a default oss conductor image version to use in situations where the org variable cannot be resolved. I think a new commit or needs to be pushed in this branch to get the CI run to use the latest main workflow, because just re-running it doesn't seem to be picking up the upstream fix. |
…sk-executor-settings
|
@chrishagglund-ship-it i synced my branch with the current main, let's see if this will work. |
Summary
Fixes
WorkflowTaskExecutorwhen it is created with an explicitWorkflowTaskExecutorConfiguration.The configured constructor did not initialize
_workerSettings, causing a null-reference failure when the executor starts or polls for tasks.Changes
_workerSettingsfrom the supplied configuration.worker.WorkerSettingswhen no explicit configuration is supplied.Validation
The new tests verify that polling uses the expected worker ID, domain, and requested task count for both configuration paths.