Make project-trust saves atomic and serialized - #506
Merged
TheGreatAxios merged 1 commit intoAug 22, 2026
Conversation
Persist project trust via temp-file + rename and serialize load-mutate-save behind a per-path mutation queue, mirroring path-trust.ts. Prevents concurrent plugin/MCP trust grants from interleaving and dropping a grant or leaving truncated JSON on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project-trust saves wrote the store file directly with no temp+rename and no mutation queue, so concurrent trust-plugin/trust-MCP updates could interleave read-mutate-write and drop a grant or leave truncated JSON. This now writes via temp-file + rename and serializes load/mutate/save behind a per-path mutation queue, mirroring the existing path-trust.ts pattern.
Adds regression tests for concurrent plugin trust, concurrent plugin+MCP trust, and many concurrent writers, asserting all grants persist and the on-disk file stays valid JSON with no leftover temp file.
Fixes CL-6705
https://linear.app/abklabs/issue/CL-6705