Stop mention popup refresh from draining queued gates - #515
Merged
TheGreatAxios merged 1 commit intoAug 22, 2026
Merged
Conversation
Every filter keystroke closed and reopened the @-mention overlay, which released the shared overlay host for one tick. A queued permission/operator gate drained into that gap and opened its own overlay; the reopen then no-op'd against the busy host while mentionPopups still claimed ownership, so later keystrokes went nowhere. Use setOverlayItems to update the open mentions list in place, only opening/closing on true entry/exit. Fixes CL-6698 https://linear.app/abklabs/issue/CL-6698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every @-mention filter keystroke closed and reopened the overlay, releasing the shared overlay host for one tick; a queued permission/operator gate could drain into that gap and open onto the host while the mention popup's own ownership tracking stayed stale. This refreshes the open mentions list in place via
setOverlayItems, only closing/opening on true open/dismiss, so a queued gate can no longer open mid-session and mention filtering keeps working across refreshes.Fixes CL-6698
https://linear.app/abklabs/issue/CL-6698