Keep cancelled worker Findings and Paths on salvage - #668
Merged
Conversation
2 tasks
TheGreatAxios
added a commit
that referenced
this pull request
Aug 24, 2026
…672) Operator cancel aborts the child signal, but run() can still return a salvage body. The spawn settle path used to drop that body when childCtl was aborted, leaving fleetRecords "running" forever so wait_agents never observed the salvage. Always resolve/reject fleetRecords; complete/fail already no-op when the strip is cancelled. Complementary to #668 (content salvage into the forced-stop envelope).
Force-stopped leaves were returning empty Paths and often only the final-turn scrap as Findings, so parents re-did completed file work. Accumulate mid-run prose and thrash paths into the catch/interrupt salvage envelope, and give cancelled runs the same parent hint shape as deadlines.
TheGreatAxios
force-pushed
the
cl-6915-cancelled-workers-keep-findings
branch
from
August 25, 2026 01:49
20bdaeb to
ca5ba60
Compare
TheGreatAxios
enabled auto-merge (squash)
August 25, 2026 01:49
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…672) Operator cancel aborts the child signal, but run() can still return a salvage body. The spawn settle path used to drop that body when childCtl was aborted, leaving fleetRecords "running" forever so wait_agents never observed the salvage. Always resolve/reject fleetRecords; complete/fail already no-op when the strip is cancelled. Complementary to #668 (content salvage into the forced-stop envelope).
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
* Keep cancelled worker Findings and Paths on salvage Force-stopped leaves were returning empty Paths and often only the final-turn scrap as Findings, so parents re-did completed file work. Accumulate mid-run prose and thrash paths into the catch/interrupt salvage envelope, and give cancelled runs the same parent hint shape as deadlines. * Fix prettier formatting in cancelled-worker salvage
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
…672) Operator cancel aborts the child signal, but run() can still return a salvage body. The spawn settle path used to drop that body when childCtl was aborted, leaving fleetRecords "running" forever so wait_agents never observed the salvage. Always resolve/reject fleetRecords; complete/fail already no-op when the strip is cancelled. Complementary to #668 (content salvage into the forced-stop envelope).
TheGreatAxios
added a commit
that referenced
this pull request
Aug 27, 2026
* Keep cancelled worker Findings and Paths on salvage Force-stopped leaves were returning empty Paths and often only the final-turn scrap as Findings, so parents re-did completed file work. Accumulate mid-run prose and thrash paths into the catch/interrupt salvage envelope, and give cancelled runs the same parent hint shape as deadlines. * Fix prettier formatting in cancelled-worker salvage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cancelled and deadline-stopped workers now salvage multi-turn Findings plus thrash Paths into the forced-stop envelope, and cancelled runs get a parent hint parallel to the deadline hint so parents continue from partial work instead of redoing it.
Verification
bun test src/subagent/thrash.test.ts src/subagent/nudge-director.test.ts src/subagent/index.test.ts(96 pass)bun run typecheckCloses CL-6915