CL-5785: Kill /approvals page; approvals in notifications band - #28
Merged
TheGreatAxios merged 2 commits intoAug 9, 2026
Conversation
Approvals were never a destination page. Remove the route and page, and render pending needs-you cards as actionable ApprovalCards in the contextual panel notifications band (with pending count badge). Backend packages/approvals is unchanged. Channel-inline approval cards and per-channel rail badges remain partial; notifications band is the primary actionable surface after the page kill.
Contributor
Author
Multi-agent review (orchestrator)Verdict: APPROVE (cannot self-approve via API) What it doesRemoves Checked
Non-blocking
Merging. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/approvalsroute and page — approvals were never a destinationApprovalCards in the contextual panel notifications band (with pending count badge)packages/approvalsbackend unchangedPartial vs full acceptance
Test plan
bun test test/routes.test.tsx test/contextual-panel.test.tsxin apps/web (16 pass)Linear: https://linear.app/abklabs/issue/CL-5785/approvals-kill-the-page-notifications-inline-channel-cards