Skip to content

CL-5785: Kill /approvals page; approvals in notifications band - #28

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-5785-approvals-kill-the-page-notifications-inline-channel-cards
Aug 9, 2026
Merged

CL-5785: Kill /approvals page; approvals in notifications band#28
TheGreatAxios merged 2 commits into
mainfrom
cl-5785-approvals-kill-the-page-notifications-inline-channel-cards

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • Delete the /approvals route and page — approvals were never a destination
  • Render pending needs-you approvals as actionable ApprovalCards in the contextual panel notifications band (with pending count badge)
  • Keep packages/approvals backend unchanged

Partial vs full acceptance

  • Done: no Approvals nav/route; actionable cards in notifications; band-level pending badge
  • Still partial: channel-inline approval cards (where the action originated) and per-channel rail badges — follow-up if not already covered by HITL run surfaces

Test plan

  • bun test test/routes.test.tsx test/contextual-panel.test.tsx in apps/web (16 pass)
  • CI checks + walking-skeleton

Linear: https://linear.app/abklabs/issue/CL-5785/approvals-kill-the-page-notifications-inline-channel-cards

Approvals were never a destination page. Remove the route and page, and
render pending needs-you cards as actionable ApprovalCards in the
contextual panel notifications band (with pending count badge). Backend
packages/approvals is unchanged.

Channel-inline approval cards and per-channel rail badges remain partial;
notifications band is the primary actionable surface after the page kill.
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Multi-agent review (orchestrator)

Verdict: APPROVE (cannot self-approve via API)

What it does

Removes /approvals as a destination page and mounts NotificationsBand globally on the contextual panel with needs-you ApprovalCards (approve once / reject + optional message). README and route tests updated; page file gone.

Checked

  • Diff vs origin/main: routes, panel contributions, notifications-band, contextual-panel, tests
  • Local web tests: routes / contextual-panel / pages — 27 pass
  • CI: checks + walking-skeleton green
  • No leftover ApprovalsPage / /approvals route; API mutations still hub-scoped

Non-blocking

  • Channel-inline approval cards / rail badges noted as partial in the commit body — intentional follow-on, not a merge blocker for the page kill.

Merging.

@TheGreatAxios
TheGreatAxios merged commit 1c7f104 into main Aug 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant