Bench chat defaults with per-channel context-window overrides - #3
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-5653-per-channel-settings
branch
from
August 9, 2026 01:46
ecd325b to
a7a4a1d
Compare
Contributor
Author
Self-critique (orchestrator)Verdict: likely merge-ready after CI + greybeard/bruckheimer Looks good
Verify
|
TheGreatAxios
force-pushed
the
cl-5653-per-channel-settings
branch
2 times, most recently
from
August 9, 2026 02:05
1c8e284 to
587ce11
Compare
Channels can now inherit their context window from a new per-tenant chat_bench_settings table instead of only ever reading a code-level constant; chat/contextWindow becomes nullable (null/absent means inherit) and a new resolveContextWindow function folds a channel's override against the bench default into one effective value, exposed through GET/PATCH /channels/:id/settings and a new GET/PATCH /bench/settings route. A migration makes every pre-existing row's implicit default explicit as null rather than silently reinterpreting already-set values.
chat/contextWindow is now a bench-wide default every channel inherits, so the chat settings section edits only that single number rather than per-channel values. context-window.ts keeps null meaning "not ready to submit" for the bench-default field (a bench default is never itself an inherited value — there is nothing beneath it), distinct from a channel's own nullable override which means "inherit."
A channel's settings dialog (ChannelSettingsPanel) surfaces name, pinned,
and the context-window inherit/override control driven by the resolved
{ value, source } shape from the channel and bench settings routes:
"Use bench default (N)" vs an explicit numeric override, where choosing
inherit always PATCHes chat/contextWindow back to null. The sidebar's
each row gains a hover-revealed ellipsis menu (rename, pin/unpin, open
settings) wrapping the existing row button, preserving the legacy badge
and agent badge from the app-shell layout.
Adds the "Bench defaults and per-channel overrides" section and the GET/PATCH /bench/settings and /channels/:id/settings routes to the HTTP surface table, covering the null-means-inherit semantics and the resolveContextWindow folding behind both UI controls.
TheGreatAxios
force-pushed
the
cl-5653-per-channel-settings
branch
from
August 9, 2026 02:28
587ce11 to
7703e26
Compare
Per-channel settings adds a fifth chat product table for bench defaults.
Contributor
Author
|
Greybeard: MERGE — bench default + per-channel context-window inherit/override; arktype; grant-gated. |
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bench-wide chat defaults plus per-channel context-window overrides in chat-ui and settings-ui.
Test plan