Skip to content

CL-5850: Activity band (rename + hide when empty) - #35

Merged
TheGreatAxios merged 3 commits into
mainfrom
cl-5850-activity-global-band
Aug 10, 2026
Merged

CL-5850: Activity band (rename + hide when empty)#35
TheGreatAxios merged 3 commits into
mainfrom
cl-5850-activity-global-band

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • Rename NotificationsActivity (activity-band.tsx)
  • Band hides entirely when needs-you resolves empty; stays while loading / with items
  • Global: still mounted from the contextual panel on every page

Linear

https://linear.app/abklabs/issue/CL-5850

Test plan

  • bun test ./test/contextual-panel.test.tsx from apps/web
  • Manual: empty needs-you → no Activity heading
  • Manual: pending approval → Activity band with card, approve/reject still works

Independence

Standalone off main. Same-file touch as CL-5851 on contextual-panel.tsx only (import/component swap vs hide-empty pins).

The product name for the global needs-you surface is Activity. Rename
the band, keep it mounted on every page, and drop the hollow empty
state so the band only appears while loading or when items exist.
@TheGreatAxios
TheGreatAxios force-pushed the cl-5850-activity-global-band branch from e7a122c to 2786b7d Compare August 10, 2026 01:04
The responsive drawer path rendered ContextualPanel without the
canvas open handler, which fails typecheck after that prop became
required.
@TheGreatAxios
TheGreatAxios merged commit 7fbf4cf into main Aug 10, 2026
2 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-5850-activity-global-band branch August 10, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant