Merge workbench settings patches under a row lock - #519
Merged
TheGreatAxios merged 2 commits intoAug 31, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-7251-workbench-settings-patch-route-still-whole-blob-writes
branch
from
August 30, 2026 21:44
49298af to
a697078
Compare
TheGreatAxios
force-pushed
the
cl-7251-workbench-settings-patch-route-still-whole-blob-writes
branch
2 times, most recently
from
August 30, 2026 23:36
e8b089a to
f11f9d2
Compare
A PATCH that only touches chat/pinned must keep a concurrent chat/participants write. Cover the in-memory store, the HTTP route, and the drizzle row lock.
The PATCH handler no longer whole-blob-writes a pre-request snapshot. patchWorkbenchSettings SELECT ... FOR UPDATE the workbench_settings row and merges only the keys the caller sent, so a pinned-flag write cannot revert a concurrent invite.
TheGreatAxios
force-pushed
the
cl-7251-workbench-settings-patch-route-still-whole-blob-writes
branch
from
August 31, 2026 01:35
f11f9d2 to
7a61fe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workbench settings PATCH used to merge onto a snapshot taken at the start of the request and then whole-blob-write it. A PATCH that only set
chat/pinnedcould revert a concurrent invite that had updatedchat/participants.patchWorkbenchSettingsnow takes aSELECT ... FOR UPDATElock on theworkbench_settingsrow and merges only the keys in the patch. The PATCH handler calls that instead of snapshot-merge +updateWorkbenchSettings. Participants are still normalized in the route before the write.Closes CL-7251